elharo commented on a change in pull request #34: [MJAVADOC-628] - add
javadoc.io link pattern when <detectLink> option is …
URL:
https://github.com/apache/maven-javadoc-plugin/pull/34#discussion_r405426047
##########
File path:
src/test/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojoTest.java
##########
@@ -87,4 +88,20 @@ public void testMJAVADOC527_DetectLinksRecursion()
assertFalse( mojo.isValidJavadocLink(
"http://javamail.java.net/mailapi/apidocs";, false ) );
assertTrue( mojo.isValidJavadocLink(
"http://commons.apache.org/proper/commons-lang/apidocs";, false ) );
}
+
+ public void test_urlEncode()
Review comment:
Let's try not to make a general URL encoding utility and test through the
public API.
There are better libraries to encode than URLEncoder though I'm not sure
which are in our dependency tree already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
