rfscholte commented on a change in pull request #8:
URL: https://github.com/apache/maven-gpg-plugin/pull/8#discussion_r414057909
##########
File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java
##########
@@ -19,19 +19,30 @@
* under the License.
*/
+import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import org.apache.maven.plugins.gpg.GpgVersion;
import org.junit.Test;
+/**
+ * Tests for {@link GpgVersion}.
+ */
public class GpgVersionTest
{
@Test
public void test()
{
- assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) ) );
- assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "2.1" ) ) );
- assertTrue( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10"
).isAtLeast( GpgVersion.parse( "2.2.10" ) ) );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" )
+ .compareTo( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) ), 0 );
+
+ assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" )
+ .isAtLeast( GpgVersion.parse( "2.1" ) ) );
+
+ assertEquals( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10" )
+ .compareTo( GpgVersion.parse( "2.2.10" ) ), 0 );
+
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)" )
Review comment:
I'm the one to blame. `GpgVersion` is a Comparable Object. In the code
you're only interest in `before` or `atLeast` some value, you're never
interested in equals. This might make the testcode look a bit weird.
Equals compares the raw value, including implementation, and that is not
what you want here: the value of the version should be matched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
