[ 
https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097338#comment-17097338
 ] 

Cintia DR edited comment on WAGON-590 at 5/1/20, 12:33 PM:
-----------------------------------------------------------

Either I didn't understand the instructions, or the branch is not running. 



Using this commit:

 
{code:java}
~/code/maven-wagon (WAGON-590:git) $ git log
508c5c82 - Michael Osipov - (HEAD -> WAGON-590, origin/WAGON-590) Disable 
preemptive and scoped auth (21 hours ago)
{code}
 
I went to maven:

{code:java}
~/code/maven (master:git) $ git log
be16fc66b - Christian Schulte - (HEAD -> master, origin/master, origin/HEAD) 
[MNG-2478] add "resources-filtered" filtered resource directories to super POM 
(4 days ago)
{code}

Modified the version of Wagon:

{code}
~/code/maven (master:git) $ git diff
diff --git a/pom.xml b/pom.xml
index 42dc0b1c1..0d0963e13 100644
--- a/pom.xml
+++ b/pom.xml
@@ -59,7 +59,7 @@ under the License.
 <plexusUtilsVersion>3.3.0</plexusUtilsVersion>
 <guiceVersion>4.2.2</guiceVersion>
 <sisuInjectVersion>0.3.4</sisuInjectVersion>
- <wagonVersion>3.4.0</wagonVersion>
+ <wagonVersion>3.4.1-SNAPSHOT</wagonVersion>
 <jsoupVersion>1.12.1</jsoupVersion>
 <securityDispatcherVersion>1.4</securityDispatcherVersion>
 <cipherVersion>1.8</cipherVersion>
{code}

And attempted to run the mvn binary later. It's throwing an exception, 
regardless of what I try.

(using the following logs config for all runs:
org.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug
org.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient.wire=error)

-----
(WAGON-590 branch)
$ mvn deploy 
-> mvn-wagon590branch-osx.log

(WAGON-590 branch)
$ mvn -X -B deploy
-> mvn-wagon590branch-debug-osx.log

————
I also did a master batch run (just redacted my creds)

(master branch)
mvn deploy -X -B
-> mvn-master-batch-osx.log





was (Author: cintiadr):
Either I didn't understand the instructions, or the branch is not running. 



Using this commit:

 
{code:java}
~/code/maven-wagon (WAGON-590:git) $ git log
508c5c82 - Michael Osipov - (HEAD -> WAGON-590, origin/WAGON-590) Disable 
preemptive and scoped auth (21 hours ago)
{code}
 
I went to maven:

{code:java}
~/code/maven (master:git) $ git log
be16fc66b - Christian Schulte - (HEAD -> master, origin/master, origin/HEAD) 
[MNG-2478] add "resources-filtered" filtered resource directories to super POM 
(4 days ago)
{code}

Modified the version of Wagon:

{code}
~/code/maven (master:git) $ git diff
diff --git a/pom.xml b/pom.xml
index 42dc0b1c1..0d0963e13 100644
--- a/pom.xml
+++ b/pom.xml
@@ -59,7 +59,7 @@ under the License.
 <plexusUtilsVersion>3.3.0</plexusUtilsVersion>
 <guiceVersion>4.2.2</guiceVersion>
 <sisuInjectVersion>0.3.4</sisuInjectVersion>
- <wagonVersion>3.4.0</wagonVersion>
+ <wagonVersion>3.4.1-SNAPSHOT</wagonVersion>
 <jsoupVersion>1.12.1</jsoupVersion>
 <securityDispatcherVersion>1.4</securityDispatcherVersion>
 <cipherVersion>1.8</cipherVersion>
{code}

And attempted to run the mvn binary later. It's throwing an exception, 
regardless of what I try.

(using the following logs config for all runs:
org.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient=debug
org.slf4j.simpleLogger.log.org.apache.maven.wagon.providers.http.httpclient.wire=error)

-----
(WAGON-590 branch)
$ mvn deploy 
-> mvn-wagon590branch-osx.log

(WAGON-590 branch)
$ mvn -X -B deploy
-> mvn-wagon590branch-debug-osx.log

————
I also did a master batch run (just redacted my creds)

(master branch)
mvn deploy -X -B
-> mvn-master-batch.log




> Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect
> -----------------------------------------------------------------------
>
>                 Key: WAGON-590
>                 URL: https://issues.apache.org/jira/browse/WAGON-590
>             Project: Maven Wagon
>          Issue Type: Bug
>            Reporter: Cintia DR
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>         Attachments: Screen Shot 2020-04-28 at 7.45.33 pm.png, 
> master_osx.log, master_ubuntu.log, maven_x.log, mvn-master-batch.log, 
> mvn-wagon590branch-debug-osx.log, mvn-wagon590branch-osx.log, mvn339_osx.log, 
> mvn339_ubuntu.log
>
>
> Since maven 3.5.0 (including 3.6.3), maven seems to not send server 
> credentials if distributionManagement server response was a 301 or 302 HTTP 
> redirect. Note that the redirect is followed, but I receive unauthorised code.
> Maven 3.2.5 and 3.3.9 work as expected. I could reproduce it on ubuntu and 
> OSX. Both are JDK 8, not sure if it could make any difference.
>  
> All maven versions (including 3.2.5 and 3.3.9) are using the same version of 
> the deploy plugin (2.7), and upgrading it made no difference whatsoever.
> ----
> If I use '[https://openmrs.jfrog.io/artifactory/snapshots/'] as my 
> 'distributionManagement', credentials are sent.
> If I use 
> '[https://mavenrepo.openmrs.org/proxy/snapshots/|https://mavenrepo.openmrs.org/snapshots/']'
>  (a reverse proxy to 
> '[https://openmrs.jfrog.io/artifactory/snapshots/|https://openmrs.jfrog.io/artifactory/snapshots/']')
>  credentials are sent.
> If I use '[https://mavenrepo.openmrs.org/snapshots/'] (a 301 redirect to 
> [https://openmrs.jfrog.io/artifactory/snapshots/|https://openmrs.jfrog.io/artifactory/snapshots/'])
>  as my distributionManagement, credentials are _not_ sent and the request 
> fails as it's unauthenticated. 
>  
> You can see the configuration of 'mavenrepo.openmrs.org' server here: 
> [https://github.com/openmrs/openmrs-contrib-itsmresources/blob/master/ansible/host_vars/campo.openmrs.org/vars#L33]
>  
> All my artefacts are public to download, so I don't have a way to testing 
> downloading artefacts with server credentials.
>  
> ----
> This is how the output looks like in maven 3.6.3:
> {code:java}
>  
> [INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @ 
> releasetestmodule ---
> Downloading from openmrs-repo-snapshots: 
> https://mavenrepo.openmrs.org/nexus/content/repositories/snapshots/org/openmrs/module/releasetestmodule/2.1.22-SNAPSHOT/maven-metadata.xml
> Downloaded from openmrs-repo-snapshots: 
> https://mavenrepo.openmrs.org/nexus/content/repositories/snapshots/org/openmrs/module/releasetestmodule/2.1.22-SNAPSHOT/maven-metadata.xml
>  (616 B at 132 B/s)
> Uploading to openmrs-repo-snapshots: 
> https://mavenrepo.openmrs.org/nexus/content/repositories/snapshots/org/openmrs/module/releasetestmodule/2.1.22-SNAPSHOT/releasetestmodule-2.1.22-20200427.091851-13.pom
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on 
> project releasetestmodule: Failed to deploy artifacts: Could not transfer 
> artifact org.openmrs.module:releasetestmodule:pom:2.1.22-20200427.091851-13 
> from/to openmrs-repo-snapshots 
> (https://mavenrepo.openmrs.org/nexus/content/repositories/snapshots): 
> Transfer failed for 
> https://openmrs.jfrog.io/artifactory/snapshots/org/openmrs/module/releasetestmodule/2.1.22-SNAPSHOT/releasetestmodule-2.1.22-20200427.091851-13.pom
>  401 Unauthorized -> [Help 1]{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to