pzygielo opened a new pull request #46:
URL: https://github.com/apache/maven-dependency-plugin/pull/46


   I propose this change to resolve 
[MDEP-680](https://issues.apache.org/jira/browse/MDEP-680).
   
   My understanding is as follows:
   1. both `o.a.m...internal.Maven30DependencyResolver.resolveDependencies` and 
`o.a.m...internal.Maven31DependencyResolver.resolveDependencies` use 
`buildingRequest.getRemoteRepositories()`
   2. `ResolvePluginsMojo` sets them explicitly: 
https://github.com/apache/maven-dependency-plugin/blob/6adc71cceb0cc8bfc05d0b6d1ff72652d7e39f33/src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolvePluginsMojo.java#L200
 but `GoOffline` doesn't. Thus as I observed effectively only central is used.
   
   I recorded my steps of the preparation, actual fix and some clean-up in 
separate commits.
   
   I'm pretty sure about the code change, as I successfully used new 
`go-offline` from snapshot plugin with several (multi-module, parent-child) 
projects with dependencies and plugins from multiple (i.e. non-central) 
repositories.
   
   
   ---
   
    - [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to