michael-o commented on a change in pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#discussion_r422948794
##########
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java
##########
@@ -52,7 +53,8 @@
{
GitStatusConsumer consumer = new GitStatusConsumer( new DefaultLog(),
null, relativeRepoPath );
- try ( BufferedReader r = new BufferedReader( new FileReader( gitlog )
) )
+ try ( BufferedReader r = new BufferedReader(
+ new InputStreamReader ( new FileInputStream( gitlog ),
StandardCharsets.UTF_8 ) ) )
Review comment:
I don't know whether this is better. If we read from stdin or the stdin
has been redirected and the encoding was not UTF-8 and did contain multibyte
characters the reader will show errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
