mthmulders commented on a change in pull request #67:
URL: https://github.com/apache/maven-wagon/pull/67#discussion_r427048402
##########
File path:
wagon-provider-api/src/main/java/org/apache/maven/wagon/authentication/AuthenticationInfo.java
##########
@@ -51,7 +52,300 @@
* The absolute path to private key file
*/
private String privateKey;
+
+ /**
+ *
+ *
+ * The path to the trust store. If not defined, the JRE's cacert store is
+ * used.
+ *
+ *
+ */
+ private String trustStore;
+
+ /**
+ *
+ *
+ * The password to the trust store.
+ *
+ *
+ */
+ private String trustStorePassword;
Review comment:
This field contains a password. We must convert it to `char[]` later on,
so can't we store it as a `char[]`?
##########
File path:
wagon-provider-api/src/main/java/org/apache/maven/wagon/authentication/AuthenticationInfo.java
##########
@@ -51,7 +52,300 @@
* The absolute path to private key file
*/
private String privateKey;
+
+ /**
+ *
+ *
+ * The path to the trust store. If not defined, the JRE's cacert store is
+ * used.
+ *
+ *
+ */
+ private String trustStore;
+
+ /**
+ *
+ *
+ * The password to the trust store.
+ *
+ *
+ */
+ private String trustStorePassword;
+
+ /**
+ *
+ *
+ * The type of trust store, default is JKS
+ *
+ * .
+ */
+ private String trustStoreType;
+
+ /**
+ *
+ *
+ * The path to the keystore used for authentication purposes, or null
+ *
+ * .
+ */
+ private String keyStore;
+
+ /**
+ *
+ *
+ * Keystore password, can be null
+ *
+ * .
+ */
+ private String keyStorePassword;
Review comment:
This field contains a password. We must convert it to `char[]` later on,
so can't we store it as a `char[]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
