roxspring commented on a change in pull request #31:
URL: https://github.com/apache/maven-shared-utils/pull/31#discussion_r427593386
##########
File path: src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java
##########
@@ -1475,6 +1475,30 @@ public void createAndReadSymlink()
Files.delete( file.toPath() );
}
+ @Test
+ public void createSymbolicLinkWithDifferentTargetOverwritesSymlink()
+ throws Exception
+ {
+ assumeThat( System.getProperty( "os.name" ), not( startsWith(
"Windows" ) ) );
Review comment:
Unified explicit calls on `assumeFalse( Os.isFamily( Os.FAMILY_WINDOWS )
);`.
I've left the various path based assumptions as is for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
