bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r429159142
##########
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
##########
@@ -58,7 +59,9 @@ public ReleaseDescriptorBuilder addCheckModificationExclude(
String string )
public ReleaseDescriptorBuilder setActivateProfiles( List<String> profiles
)
{
- releaseDescriptor.setActivateProfiles( profiles );
+ List<String> copy = new ArrayList<>();
+ copy.addAll( profiles );
Review comment:
> there are 3 ways of merging ..
You do not answer my question. When you say
> copyPropertiesToReleaseDescriptor means: if property exists, apply that to
release descriptor
What should it do in case of a collection ? what "apply" means in your
sentence : override existing value, or append to it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
