rfscholte commented on a change in pull request #351:
URL: https://github.com/apache/maven/pull/351#discussion_r429630233
##########
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
##########
@@ -687,6 +687,11 @@ public MavenExecutionRequest setPom( File pom )
{
this.pom = pom;
+ if ( this.pom != null && this.pom.getParentFile() != null )
Review comment:
IIRC this will go wrong. There are a couple of plugins that want to
rewrite the pom (maven-shade-plugin, flatten-maven-plugin). This pom will be in
the target directory, so it can be cleaned up. However, the basedir should stay
the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
