michael-o commented on a change in pull request #36:
URL: https://github.com/apache/maven-shared-utils/pull/36#discussion_r431312220



##########
File path: src/main/java/org/apache/maven/shared/utils/io/FileUtils.java
##########
@@ -573,10 +575,10 @@ private static boolean isValidFile( @Nonnull String file, 
@Nonnull String... ext
     }
 
     /**
-     * Simple way to make a directory
+     * Simple way to make a directory.
      *
      * @param dir the directory to create
-     * @throws IllegalArgumentException if the dir contains illegal Windows 
characters under Windows OS.
+     * @throws IllegalArgumentException if the dir contains illegal Windows 
characters under Windows OS
      * @see #INVALID_CHARACTERS_FOR_WINDOWS_FILE_NAME
      */
     public static void mkdir( @Nonnull String dir )

Review comment:
       Won't Files#createDirectory()` properly fail in such a case? If so, I 
would rather rely on this one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to