[
https://issues.apache.org/jira/browse/MSKINS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MSKINS-168.
--------------------------------
Fix Version/s: fluido-2.0
Assignee: Herve Boutemy
Resolution: Fixed
PR merged in
https://github.com/apache/maven-fluido-skin/commit/f966972c504c8a01a5d7a203de6438464877a8bd
thank you [~dialaya]
> Switch Minification Engine from YUI to CLOSURE
> ----------------------------------------------
>
> Key: MSKINS-168
> URL: https://issues.apache.org/jira/browse/MSKINS-168
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.9
> Reporter: Bakary DJIBA
> Assignee: Herve Boutemy
> Priority: Major
> Labels: anchorjs, bootstrap, js, jsEngine, minification
> Fix For: fluido-2.0
>
>
> While working on Issues to add deep anchors(MSKINS-167) and Upgrade to
> Bootstrap 4 (MSKINS-97) the default jsEngine used by
> [minify-maven-plugin|https://samaxes.github.io/minify-maven-plugin/] raises
> issues during minify compile's step.
> Below the affected js libs:
> [bootstrap upgrade]
> + boostrap.bundle-4.4.1.js,
> + jquery-3.4.1.js
> [deep anchor features]
> + anchor-4.2.2.js
> I managed to modify anchor source file to workaround YUI issue (by replacing
> {{opts.class}} with {{opts['class']}}, seems to be a known limitation of YUI
> https://github.com/yui/yuicompressor/issues/77), but it will be hard to
> maintain, and definitely not an option for bootstrap upgrade
> These problems are fixed by a switch to CLOSURE engine.
> Therefore a this improvement seems useful or mandatory for Upgrading
> Bootstrap to version 4. Also to avoid modification in anchor js lib.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
