[
https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118128#comment-17118128
]
Robert James Oxspring commented on MSHARED-431:
-----------------------------------------------
Adding {{'#'}} to {{BASH_QUOTING_TRIGGER_CHARS}} is indeed fairly straight
forward and can be demonstrated with a simple test.
Looking for the specifications of exactly what characters _should_ be quoted I
noticed
[this|https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_02]
suggesting that {{'\\'}}, {{'\"'}}, {{'\''}}, {{'\t'}}, {{'\n'}}, {{'˜'}},
{{'='}}, {{'%'}} ought to also be added. Any opinions out there as to whether
we should be adding the entire list vs purposely omitting some/all of these
additions?
> # (Hash-Sign) should trigger quoting in BourneShell.java
> --------------------------------------------------------
>
> Key: MSHARED-431
> URL: https://issues.apache.org/jira/browse/MSHARED-431
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-shared-utils
> Affects Versions: maven-shared-utils-0.8
> Environment: Unix (Linux)
> Reporter: Fritz Elfert
> Priority: Major
>
> When trying to use the latest maven-jarsign-plugin using a keystore-password
> which started with a hash (#), signing failed. After enabling debug output
> with -X, I got a strange debug message:
> [DEBUG] Option lacks argument
> Since signtool is invoked using /bin/sh -c ..., of course, any # must be
> quoted, because otherwise it acts as a comment-start and thus effectively
> cuts-off the rest of the cmdline.
> After single-quoting the password in the pom.xml, the jar signing was ok.
> =>
> Adding '#' to BASH_QUOTING_TRIGGER_CHARS in
> org.apache.maven.shared.utils.cli.shell.BourneShell.java should fix the
> problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
