elharo commented on a change in pull request #48:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r436294565
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
##########
@@ -808,20 +808,6 @@ private void parseClirrTextOutputFile( File
clirrTextOutputFile )
switch ( code )
{
case 7011:
Review comment:
fallthrough is dangerous; perhpas extrat a helper method instead
##########
File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
##########
@@ -629,35 +650,34 @@ protected static String parseJavadocMemory( String memory
)
throw new IllegalArgumentException( "The memory could not be
null." );
}
- Pattern p = Pattern.compile( "^\\s*(\\d+)\\s*?\\s*$" );
+ Pattern p = PARSE_JAVADOC_MEMORY_PATTERN_0;
Review comment:
renaming this MEMORY_PATTERN_N does not help, arguably it makes this
worse by making one look up the pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
