rfscholte commented on a change in pull request #286:
URL: https://github.com/apache/maven/pull/286#discussion_r439853476
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -646,8 +657,33 @@ else if ( modelSource instanceof FileModelSource )
{
model.setPomFile( ( (FileModelSource) modelSource ).getFile() );
}
-
problems.setSource( model );
+
+ modelValidator.validateFileModel( model, request, problems );
+ request.setFileModel( model );
+
+ if ( Features.buildConsumer().isActive() && pomFile != null )
+ {
+ try
Review comment:
Building the model is matter of a lot of steps. I gave it a try, but it
actually made the code harder to understand, because some clear if/else or
foreach statements make more sense within this context.
One might give it a try, but not as part of this ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
