XenoAmess commented on a change in pull request #48:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133256
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -6066,23 +6066,15 @@ private URL getResource( final List<String> classPath,
final String resource )
getLog().error( "MalformedURLException: " + e.getMessage() );
}
}
-
- URLClassLoader javadocClassLoader = new URLClassLoader( urls.toArray(
new URL[urls.size()] ), null );
- try
+ URL resourceURL = null;
+ try ( URLClassLoader javadocClassLoader = new URLClassLoader(
urls.toArray( new URL[urls.size()] ), null ) )
{
- return javadocClassLoader.getResource( resource );
- }
- finally
+ resourceURL = javadocClassLoader.getResource( resource );
+ } catch ( IOException e )
Review comment:
@elharo It seems only can throw when closing the `javadocClassLoader`.
the original codes ignore it in `finally`. the new codes ignore it in `catch`.
same thing IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
