elharo commented on a change in pull request #48:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443135150
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -6066,23 +6066,15 @@ private URL getResource( final List<String> classPath,
final String resource )
getLog().error( "MalformedURLException: " + e.getMessage() );
}
}
-
- URLClassLoader javadocClassLoader = new URLClassLoader( urls.toArray(
new URL[urls.size()] ), null );
- try
+ URL resourceURL = null;
+ try ( URLClassLoader javadocClassLoader = new URLClassLoader(
urls.toArray( new URL[urls.size()] ), null ) )
{
- return javadocClassLoader.getResource( resource );
- }
- finally
+ resourceURL = javadocClassLoader.getResource( resource );
+ } catch ( IOException e )
Review comment:
There's something I'm not seeing here. Have you tried simply removing
the catch block completely? Does that compile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
