mthmulders opened a new pull request #363:
URL: https://github.com/apache/maven/pull/363
This pull request is a follow-up on #342, in which two little bugs had
sneaked in. Since the feature hasn't been released yet, I haven't added new
JIRA tickets for these bugs.
1. Resolution of **resume.properties** file didn't work as expected. I have
fixed it and added a unit test to illustrate how it should work.
1. When the `excludedProjects` property in the **resume.properties** file
was empty, the build would break (since it added an empty project to the list
of excluded projects). Of course, this shouldn't happen, so that's fixed too.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA
issue. Best practice is to use the JIRA issue title in the pull request title
and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its] successfully. Also, the
previously added test case for this feature is now added to the suite.
**ICLA has been signed by @MartinKanters and myself. CCLA has been signed by
our employer, Info Support.**
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
