kwin commented on a change in pull request #62:
URL: https://github.com/apache/maven-resolver/pull/62#discussion_r444049194
##########
File path:
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
##########
@@ -338,11 +338,11 @@ public void testCheckMetadataSessionStateModes()
resetSessionData( session );
manager.touchMetadata( session, check );
- session.setConfigProperty(
DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "true" );
+ session.setConfigProperty(
DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "enabled" );
manager.checkMetadata( session, check );
assertEquals( false, check.isRequired() );
- session.setConfigProperty(
DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "false" );
+ session.setConfigProperty(
DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "disabled" );
Review comment:
for backwards compatibility reasons I would still leave the old test
cases in place relying on `true` or `false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
