[ 
https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147402#comment-17147402
 ] 

Gili commented on SUREFIRE-1811:
--------------------------------

Pavel,

Okay, it sounds like I'm misunderstanding something here. On the one hand, 
you're saying that your integration tests only access public classes. On the 
other hand, you're saying there are some classes that should only be accessible 
by your integration tests but not anyone else. Can you please clarify this 
further for me?

> I think this way src/main/java/module-info is descriptor that is used in 
>production, so we shouldn't have there any entries for testing. It is logical, 
>isn't it?

Christian was saying the same thing but I believe this is a misunderstanding of 
what module-info.java is all about. The primary purpose of this file is to 
define the module from the exporter's perspective, for *all* consumers ... not 
just for one of them. It sounds like you want to be able to define a different 
descriptor for each kind of consumer.

I hope this helps.

> Add resources to JPMS test module
> ---------------------------------
>
>                 Key: SUREFIRE-1811
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1811
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Failsafe Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Pavel_K
>            Priority: Major
>
> I am testing version 3.0.0-M5 with two module-info in one project - one main 
> and one for test. My test project is here 
> https://github.com/PashaTurok/hibernate-h2-test4 . The problem is with 
> resources. For example, I have  src/main/resources/META-INF/persistence.xml 
> file that is not copied to test module. Because of this it is not possible to 
> find resource in test module and it is necessary to use something like this 
> https://github.com/PashaTurok/hibernate-h2-test4/blob/292e2e683ad72487cbf8d2e5a35dde0d9255001a/src/test/java/com/foo/hibernate/h2/test4/TestIT.java#L72
>  . 
> In target/test-classes/META-INF/jpms.args I see:
> {code:java}
> --patch-module
> my.project=/home/..../hibernate-h2-test4/src/main/java, 
> /home/.../hibernate-h2-test4/target/generated-sources/annotations
> {code}
> As I understand test module will NOT contain resources from the module under 
> test? I mean that test module will NOT contain 
> /home/..../hibernate-h2-test4/src/main/resources? 
> That's why I suggest to include src/main/resources in test module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to