raphw commented on pull request #59: URL: https://github.com/apache/maven-shade-plugin/pull/59#issuecomment-653126880
Yes, your approach would probably be an even better solution since it still allows to shade the sources jar's manifest file. My particular issue is the `Bundle-SymbolicName` entry which is supposed to be unique. If it is also contained in the source.jar, the jar will be interpreted as a conflicting OSGi bundle if loaded by an OSGi class loader, even if only the sources are required. When using the `maven-bundle-plugin` in conjuction with the `maven-source-plugin`, the first plugin only adds manifest entries to the manifest of the actual jar file. But when using the `maven-bundle-plugin` with the `maven-shade-plugin`, this is not the case if the shade plugin is also creating a shaded source jar where the manifest will be included with the OSGi headers. It is this scenario that I would like to avoid. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
