[ 
https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150878#comment-17150878
 ] 

Rainer Reich edited comment on MRESOLVER-123 at 7/3/20, 9:51 AM:
-----------------------------------------------------------------

Added the log: [^successful-sha1-log.txt]

I did ~50 runs of one of our projects and could not see any performance impact.

The 1000 runs were executed over weeks / months of regular CI executions using 
our patched Maven everywhere.

I don't know how fast we could deploy a patch with your version, because of our 
Nexus-checksum-problem... But I could cherry-pick your fix onto 1.4.1 and 
create a patched Maven for our CI, or is there some other important change we'd 
be missing then?


was (Author: rreich):
Added the log: [^successful-sha1-log.txt]

The 1000 runs were executed over weeks / months of regular CI executions using 
our patched Maven everywhere.

I don't know how fast we could deploy a patch with your version, because of our 
Nexus-checksum-problem... But I could cherry-pick your fix onto 1.4.1 and 
create a patched Maven for our CI, or is there some other important change we'd 
be missing then?

> Concurrency issues
> ------------------
>
>                 Key: MRESOLVER-123
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-123
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: resolver
>    Affects Versions: 1.4.2
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: checksum-error-debug.log, successful-sha1-log.txt
>
>
> This is an umbrella ticket for a long standing issue with Maven Resolver: Our 
> concurrency support is mediocre in a way that if two or more threads try to 
> download the same file and fail to queue those write actions nicely. The 
> problem is that The {{SyncContext}} and the its factory provided by Maven 
> Resolver does not employ any locking at all. As layed out in detail in 
> MRESOLVER-114 we need striped read write locks on artifacts and its metadata. 
> This issue shall track progress on it. Even Takari Concurrent Repository 
> extension does not help because it is only intended to synchronize concurrent 
> access by multple JVMs and not threads.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to