rmannibucau commented on pull request #16:
URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656712557
try/with/resource should work - we did something close in tomee - but I
think the classloader should be drop to quit fast the previous loop. Idea is to
iterate over classpathElements and if it is a jar (endsWith(".jar") should be
more than enough since folders will likely not contain these classes for a war
project) then open it with JarFile and check it has one of the two entries
tested - hitting zip dictionary so fast. Will likely avoid to go through all
the classpath (often the API are at the beginning of deps) and save to create a
ton of JarLoaders for nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
