elharo commented on a change in pull request #14:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453006508
##########
File path:
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
##########
@@ -189,6 +210,29 @@ else if ( file != null && file.isDirectory() )
return artifactClassMap;
}
+ protected Set<String> buildTestDependencyClasses( MavenProject project )
throws IOException
Review comment:
It is very common to make methods overly open. Thus I wouldn't assume
that the existing methods should have been protected. We can always make
private methods more public if we discover a need. It is much harder to make a
public method private again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
