rmannibucau commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r458275537
########## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/AbstractMasterProcessChannelProcessorFactory.java ########## @@ -0,0 +1,106 @@ +package org.apache.maven.surefire.booter.spi; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.surefire.api.util.internal.WritableBufferedByteChannel; +import org.apache.maven.surefire.spi.MasterProcessChannelProcessorFactory; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.security.AccessControlException; +import java.security.PrivilegedAction; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.atomic.AtomicLong; + +import static java.security.AccessController.doPrivileged; +import static java.util.concurrent.Executors.newScheduledThreadPool; +import static java.util.concurrent.TimeUnit.MILLISECONDS; +import static org.apache.maven.surefire.api.util.internal.DaemonThreadFactory.newDaemonThreadFactory; + +/** + * Default implementation of {@link MasterProcessChannelProcessorFactory}. + */ +public abstract class AbstractMasterProcessChannelProcessorFactory + implements MasterProcessChannelProcessorFactory +{ + private static final String STREAM_FLUSHER = "surefire-forkedjvm-stream-flusher"; + private final ScheduledExecutorService flusher; + + public AbstractMasterProcessChannelProcessorFactory() + { + flusher = newScheduledThreadPool( 1, newDaemonThreadFactory( STREAM_FLUSHER ) ); Review comment: I think there is never any reason to not handle the lifecycle of the object you create properly. System.exit cleanup order is not deterministic (in particular across JVM and versions) and you literally let a thread leak there assuming the OS cleans it up. It also depends your glic version (see https://www.man7.org/linux/man-pages/man2/_exit.2.html). So even not technically I would shutdown properly any started thread in the app + here you will not add any latency since it will exit immediately using shutdownnow + awaitTermination (will just do a state check so will be way faster than 100ms). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
