jhaber opened a new pull request #20: URL: https://github.com/apache/maven-dependency-analyzer/pull/20
This PR is largely the same as https://github.com/apache/maven-shared/pull/21, just targeting the new repo as requested. The [JIRA](https://issues.apache.org/jira/browse/MSHARED-632) includes the full context, but the basic idea with this PR is to introduce the concept of a `DependencyUsage` and expose this in the `ProjectDependencyAnalysis`. This exposes more information about specifically which class is used and where, which can then be used by the dependency plugin to produce more detailed output. Here's an example of the output it would enable: Before: ``` [WARNING] Used undeclared dependencies found: [WARNING] com.google.inject:guice:jar:4.1.0:compile [WARNING] com.google.guava:guava:jar:19.0:compile [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ ``` After: ``` [WARNING] Used undeclared dependencies found: [WARNING] com.google.inject:guice:jar:4.1.0:compile [WARNING] - com.google.inject.Module is referenced in com.hubspot.embedrest.EmbedRestService [WARNING] - com.google.inject.Inject is referenced in com.hubspot.embedrest.v3.FormsResource [WARNING] - com.google.inject.Provides is referenced in com.hubspot.embedrest.config.EmbedModule [WARNING] - com.google.inject.Singleton is referenced in com.hubspot.embedrest.config.EmbedModule [WARNING] - com.google.inject.name.Named is referenced in com.hubspot.embedrest.config.EmbedModule [WARNING] - ... and 7 more [WARNING] [WARNING] com.google.guava:guava:jar:19.0:compile [WARNING] - com.google.common.base.Strings is referenced in com.hubspot.embedrest.v3.FormsResource [WARNING] - com.google.common.base.Optional is referenced in com.hubspot.embedrest.managers.FormDefinitionsManager [WARNING] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ ``` ----------------------------------------------------------------------------- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). (`[WARNING] The requested profile "run-its" could not be activated because it does not exist.`) If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
