elharo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r467029478
##########
File path:
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -279,6 +332,20 @@ public boolean isStreaming()
private static final boolean SSL_ALLOW_ALL =
Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall",
"false" ) );
+ /**
+ * If enabled, then the content-type HTTP header will be set using the
file extension
+ * or the stream header to determine the type, <b>enabled by default</b>
+ */
+ private static final boolean AUTOSET_CONTENT_TYPE =
+ Boolean.valueOf( System.getProperty(
"maven.wagon.http.autocontenttype", "true" ) );
+
+ /**
+ * If enabled, then an when determining the content type will result in a
fatal exception
Review comment:
an --> an error
will result --> results
##########
File path:
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -279,6 +332,20 @@ public boolean isStreaming()
private static final boolean SSL_ALLOW_ALL =
Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall",
"false" ) );
+ /**
+ * If enabled, then the content-type HTTP header will be set using the
file extension
+ * or the stream header to determine the type, <b>enabled by default</b>
+ */
+ private static final boolean AUTOSET_CONTENT_TYPE =
+ Boolean.valueOf( System.getProperty(
"maven.wagon.http.autocontenttype", "true" ) );
+
+ /**
+ * If enabled, then an when determining the content type will result in a
fatal exception
+ * <b>disabled by default</b>
+ * This flag is only effective when maven.wagon.http.autocontenttype is
set.
+ */
+ private static final boolean AUTOSET_CONTENT_TYPE_FATAL =
Review comment:
YAGNI. No one needs this. Failure should unconditionally set the
content-type to application/octet-stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
