bimargulies-google commented on a change in pull request #97:
URL:
https://github.com/apache/maven-dependency-plugin/pull/97#discussion_r473217778
##########
File path:
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphTextSerializer.java
##########
@@ -45,8 +45,16 @@ public String serialize( DependencyNode root )
// deal with root first
Artifact rootArtifact = root.getArtifact();
builder.append( rootArtifact.getGroupId() ).append( ":" ).append(
rootArtifact.getArtifactId() ).append(
- ":" ).append( rootArtifact.getExtension() ).append( ":"
).append( rootArtifact.getVersion() ).append(
- "\n" );
+ ":" ).append( rootArtifact.getExtension() ).append( ":"
).append( rootArtifact.getVersion() );
+
+ if ( root.getData().containsKey( "ContainsModule" ) )
+ {
+ builder.append( " WARNING: this tree contains a submodule and once
it reaches the submodule will print "
Review comment:
I'd write:
contains a submodule; once it reaches
##########
File path:
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphTgfSerializer.java
##########
@@ -49,7 +49,16 @@ public String serialize( DependencyNode root )
Artifact rootArtifact = root.getArtifact();
nodes.append( root.hashCode() ).append( " " ).append(
rootArtifact.getGroupId() ).append( ":" ).append(
rootArtifact.getArtifactId() ).append( ":" ).append(
rootArtifact.getExtension() ).append( ":" ).append(
- rootArtifact.getVersion() ).append( "\n" );
+ rootArtifact.getVersion() );
+
+ if ( root.getData().containsKey( "ContainsModule" ) )
+ {
+ nodes.append( " WARNING: this tree contains a submodule and once
it reaches the submodule will print "
Review comment:
this is a little hard to follow. a semicolon after the first 'submodule'
would help.
##########
File path:
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphDotSerializer.java
##########
@@ -49,7 +49,16 @@ public String serialize( DependencyNode root )
StringBuilder result = new StringBuilder( "digraph" );
result.append( " \"" ).append( rootArtifact.getGroupId() ).append( ":"
).append(
rootArtifact.getArtifactId() ).append( ":" ).append(
rootArtifact.getExtension() ).append( ":" ).append(
- rootArtifact.getVersion() ).append( "\" {" ).append( "\n" );
+ rootArtifact.getVersion() );
+
+ if ( root.getData().containsKey( "ContainsModule" ) )
+ {
+ result.append( " WARNING: this tree contains a submodule and once
it reaches the submodule will print "
Review comment:
contains a submodule; once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
