elharo commented on a change in pull request #52:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/52#discussion_r474671357



##########
File path: 
src/test/resources/unit/fix-test/expected/src/main/java/fix/test/ClassWithJavadoc.java
##########
@@ -298,4 +318,52 @@ public void nothing()
         extends RuntimeException
     {
     }
+
+    /**
+     * private method with annotation
+     */
+    @SuppressWarnings("SameReturnValue")
+    private void t000()
+    {
+        return;
+    }
+
+    /**
+     * private method with annotation

Review comment:
       This method doesn't have an annotation.

##########
File path: 
src/test/resources/unit/fix-test/expected/src/main/java/fix/test/ClassWithNoJavadoc.java
##########
@@ -69,6 +70,22 @@ public ClassWithNoJavadoc( String aString )
     {
     }
 
+    @SuppressWarnings("SameReturnValue")
+    /**
+     * <p>Constructor for ClassWithNoJavadoc.</p>
+     *
+     * @param b a {@link java.lang.Boolean} object.
+     * @since 1.1

Review comment:
       No need for `@since`
   
   I'm not sure why you want `@param` here

##########
File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
##########
@@ -1052,9 +1052,12 @@ else if ( lineNumber == javaClass.getLineNumber() )
                     {
                         if ( lineNumber == method.getLineNumber() )
                         {
-                            changeDetected |= fixMethodComment( stringWriter, 
originalContent, method, indent );
-
-                            takeCareSingleComment( stringWriter, 
originalContent, method );
+                            final boolean nowChange = fixMethodComment( 
stringWriter, originalContent, method, indent );

Review comment:
       I don't know what "nowChange" means here. Is there perhaps a better name 
for this? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to