pzygielo commented on a change in pull request #10:
URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r481249976
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -285,6 +286,11 @@ public void execute()
super.execute();
zipArchiver.setUseJvmChmod( useJvmChmod );
+ final Date parsedOutputTimestamp = new
MavenArchiver().parseOutputTimestamp( outputTimestamp );
Review comment:
> I don't think changing a method from instance to static is a major
breaking change.
But it is breaking change. Compare: [13.4.12. Method and Constructor
Declarations](https://docs.oracle.com/javase/specs/jls/se14/html/jls-13.html#jls-13.4.12).
Such change results in `IncompatibleClassChangeError`: _Expecting non-static
method..._.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
