michaelboyles commented on pull request #69: URL: https://github.com/apache/maven-resolver/pull/69#issuecomment-691661040
Iterator is a better solution. I've changed it, thanks. Java 7 means no StringJoiner, String.join or streams. Other resolver modules include lang3, which has StringUtils with a join method, but this module doesn't. So using a list was already my 5th choice. I don't see the value in pre-calculating it. You shouldn't add complexity to a class (i.e. extra fields) for something that's only intended for debugging. As a performance optimization it's also ineffective because you'd be forcing most users to eagerly compute a value they don't use, actually making performance slightly (though insignificantly) worse. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
