MartinKanters commented on a change in pull request #71:
URL:
https://github.com/apache/maven-integration-testing/pull/71#discussion_r487526420
##########
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
This test used to verify that if you execute `mvn <goal> -pl .` that
root is built (line 66) and that the subproject is not built (line 67).
The change in MNG-6981 changed the behavior of `-pl`. First it didn't build
the target project's children, now it does.
I decided to remove the assertion on line 67, since it is in my opinion an
unnecessary assertion which is not related to unit test. Also by removing the
assertion we make sure that this test will work pre and post MNG-6981.
Alternatively we could duplicate the test class with different version
restrictions. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
