mabrarov opened a new pull request #19: URL: https://github.com/apache/maven-ear-plugin/pull/19
Fixed detection if JAR module is included into classpath of particular EAR module manifest (like WAR or EJB module manifest). This is required for correct modification of Class-Path entry of manifest of EAR modules when skinnyWars option is turned on. Note that this PR has no tests (yet) but I tested it manually with feature/MEAR-267_test branch of https://github.com/mabrarov/dockerfile-test: ```bash $ git clone --branch feature/MEAR-267_test https://github.com/mabrarov/dockerfile-test.git && \ mvn -f dockerfile-test/pom.xml clean package -Ddocker.skip -Dmaven-ear-plugin.version=3.1.1-SNAPSHOT ``` where expected manifest of WAR inside built EAR, i.e. dockerfile-test/ear/target/ear-1.1.7-SNAPSHOT.ear/org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war/META-INF/MANIFEST.MF looks like: ```text Manifest-Version: 1.0 Class-Path: lib/org.apache.commons-commons-text-1.7.jar lib/org.apache .commons-commons-lang3-3.9.jar Build-Jdk-Spec: 1.8 Created-By: Maven WAR Plugin 3.3.1 git-commit: e0458e2c48333f2847abfe58b7d1d0b3e23e8941 ``` while original manifest of WAR, i.e. dockerfile-test/war/target/war-1.1.7-SNAPSHOT.war/META-INF/MANIFEST.MF looks like: ```text Manifest-Version: 1.0 Class-Path: commons-text-1.7.jar commons-lang3-3.9.jar Build-Jdk-Spec: 1.8 Created-By: Maven WAR Plugin 3.3.1 git-commit: e0458e2c48333f2847abfe58b7d1d0b3e23e8941 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
