[ 
https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215209#comment-17215209
 ] 

Gili commented on MCOMPILER-436:
--------------------------------

[~rfscholte] I see your point but I still feel that the error message is 
missing an important line of reasoning.

>From the perspective of someone who is not familiar with the implementation 
>details of Java Modules, one would think that you should be able to extract 
>the module name for the aforementioned case. I mean, there is a well-defined 
>algorithm for converting the filenames into automatic module names. There is 
>also an Automatic-Module-Name entry in the manifest file. So from the user's 
>perspective you have everything you need to extract a module name.

What the error message fails to explain is that although we can theoretically 
extract a module name, we can't in fact load the JAR file as a module.

> Cannot compile code that depends on on Apache Mina SSH due to JPMS error
> ------------------------------------------------------------------------
>
>                 Key: MCOMPILER-436
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-436
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.8.1
>            Reporter: Gili
>            Priority: Major
>         Attachments: extract-module-name.zip
>
>
> 1. Extract Testcase
> 2. Run "mvn clean install"
> 3. Build fails with:
> [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class 
> org.apache.sshd.common.file.root.RootedFileSystemProvider not in module
> [ERROR] module not found: sshd.core
> Expected behavior: The plugin should be able to extract the module name given 
> that sshd-core depends on sshd-commons which contains the aforementioned 
> provider and automatic modules can access classes outside their module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to