bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506255109
##########
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##########
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest
performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
- ReleaseDescriptor releaseDescriptor =
- loadReleaseDescriptor(
performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener()
);
+ ReleaseDescriptorBuilder builder =
+ loadReleaseDescriptorBuilder(
performRequest.getReleaseDescriptorBuilder(),
+
performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+ List<String> allProfiles = new ArrayList<>();
Review comment:
the current build is green because of the `new ArrayList( ... )` in the
unit test :
```secondBuilder.setActivateProfiles( new ArrayList(
Arrays.asList("aProfile", "bProfile") ) );```
Remove it and the build will become red. And IT WAS a MISTAKE to add it, it
is false comparing to what happens when using the plugin
This PR fix the code so that this `new ArrayList( ... )` is not needed
anymore, and the unit test is representative of the plugin usage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
