[
https://issues.apache.org/jira/browse/MRESOLVER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215660#comment-17215660
]
Michael Osipov commented on MRESOLVER-66:
-----------------------------------------
So, I went through the PR and the issue itself. The PR is useless because this
is not a local repo issue. The repos from settings are never read because the
settings file is used for almost everything, but the profiles. The profile are
only used when a model is loaded and processed by {{resolver:install}} or
{{resolver:deploy}}. If you look closely into the code you see in
{{org.apache.maven.resolver.internal.ant.AntRepoSys.collectDependencies(Task,
Dependencies, LocalRepository, RemoteRepositories)}} that
{{AetherUtils.getDefaultRepositories( project )}} is performed which in turn
does {{project.getReference( Names.ID_DEFAULT_REPOS )}}. What does that
basically mean? One needs to inject the repos from settings somewhere. Which
{{initDefaults()}} this is not possible cause the setter for settings file does
call this init method. This will result in a chicken-and-egg problem.
How does that look to you?
{noformat}
D:\Entwicklung\Projekte\MRESOLVER-66> ant test -verbose
Listening for transport dt_socket at address: 5432
Apache Ant(TM) version 1.10.5 compiled on July 10 2018
Trying the default build file: build.xml
Buildfile: D:\Entwicklung\Projekte\MRESOLVER-66\build.xml
Detected Java version: 1.8 in: C:\Program
Files\AdoptOpenJDK\jdk-8.0.265.01-hotspot\jre
Detected OS: Windows 10
parsing buildfile D:\Entwicklung\Projekte\MRESOLVER-66\build.xml with URI =
file:/D:/Entwicklung/Projekte/MRESOLVER-66/build.xml
Project base dir set to: D:\Entwicklung\Projekte\MRESOLVER-66
parsing buildfile
jar:file:/D:/Entwicklung/Programme/apache-ant-1.10.5/lib/ant.jar!/org/apache/tools/ant/antlib.xml
with URI =
jar:file:/D:/Entwicklung/Programme/apache-ant-1.10.5/lib/ant.jar!/org/apache/tools/ant/antlib.xml
from a zip file
parsing buildfile
jar:file:/D:/Entwicklung/Projekte/MRESOLVER-66/lib/maven-resolver-ant-tasks-1.2.2-SNAPSHOT-uber.jar!/org/apache/maven/resolver/ant/antlib.xml
with URI =
jar:file:/D:/Entwicklung/Projekte/MRESOLVER-66/lib/maven-resolver-ant-tasks-1.2.2-SNAPSHOT-uber.jar!/org/apache/maven/resolver/ant/antlib.xml
from a zip file
[antlib:org.apache.maven.resolver.ant] Could not load definitions from resource
org/apache/maven/resolver/ant/antlib.xml. It could not be found.
Build sequence for target(s) `test' is [test]
Complete build sequence is [test, ]
test:
[echo] Resolving a 'my-repo' artifact
[resolver:resolve] Using local repository C:\Users\mosipov\.m2\repository
(enhanced)
Using remote repository central (https://repo1.maven.org/maven2/, default,
releases)
Using remote repository my-repo (file:///D:/Repo, default, releases+snapshots)
Collecting dependencies
[resolver:resolve] Downloading
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloaded
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/maven-metadata.xml (769 B
at 28.9 KB/sec)
[resolver:resolve] Downloading
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.pom
[resolver:resolve] Downloaded
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.pom
(2 KB at 149.6 KB/sec)
[resolver:resolve] Downloading
file:///D:/Repo/org/apache/httpcomponents/client5/httpclient5/5.0.2-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
file:///D:/Repo/org/apache/httpcomponents/client5/httpclient5-parent/5.0.2-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Resolved Dependency Graph:
[resolver:resolve] com:httpclient-retry:jar:0.0.1-SNAPSHOT:compile
[resolver:resolve] org.apache.httpcomponents:httpclient:jar:4.5.11:compile
[resolver:resolve]
org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[resolver:resolve] commons-codec:commons-codec:jar:1.11:compile
[resolver:resolve] org.slf4j:slf4j-simple:jar:1.7.30:runtime
[resolver:resolve] org.slf4j:slf4j-api:jar:1.7.30:compile
[resolver:resolve] org.slf4j:jcl-over-slf4j:jar:1.7.30:runtime
[resolver:resolve]
org.apache.httpcomponents.client5:httpclient5:jar:5.0.2-SNAPSHOT:compile
[resolver:resolve]
org.apache.httpcomponents.core5:httpcore5:jar:5.0.2:compile
[resolver:resolve]
org.apache.httpcomponents.core5:httpcore5-h2:jar:5.0.2:compile
[resolver:resolve] org.redisson:redisson:jar:3.13.3:compile
[resolver:resolve] io.netty:netty-common:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-codec:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-buffer:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-transport:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-resolver:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-resolver-dns:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-codec-dns:jar:4.1.51.Final:compile
[resolver:resolve] io.netty:netty-handler:jar:4.1.51.Final:compile
[resolver:resolve] javax.cache:cache-api:jar:1.0.0:compile
[resolver:resolve]
io.projectreactor:reactor-core:jar:3.3.4.RELEASE:compile
[resolver:resolve]
org.reactivestreams:reactive-streams:jar:1.0.3:compile
[resolver:resolve] io.reactivex.rxjava2:rxjava:jar:2.2.19:compile
[resolver:resolve]
org.jboss.marshalling:jboss-marshalling-river:jar:2.0.9.Final:compile
[resolver:resolve]
org.jboss.marshalling:jboss-marshalling:jar:2.0.9.Final:compile
[resolver:resolve] org.yaml:snakeyaml:jar:1.26:compile
[resolver:resolve]
com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.11.1:compile
[resolver:resolve]
com.fasterxml.jackson.core:jackson-core:jar:2.11.1:compile
[resolver:resolve]
com.fasterxml.jackson.core:jackson-databind:jar:2.11.1:compile
[resolver:resolve]
com.fasterxml.jackson.core:jackson-annotations:jar:2.11.1:compile
[resolver:resolve] net.bytebuddy:byte-buddy:jar:1.10.7:compile
[resolver:resolve] org.jodd:jodd-bean:jar:5.0.13:compile
[resolver:resolve] org.jodd:jodd-core:jar:5.0.13:compile
[resolver:resolve] Resolving artifacts
[resolver:resolve] Downloading
file:///D:/Repo/org/apache/httpcomponents/client5/httpclient5/5.0.2-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.jar
[resolver:resolve] Downloaded
file:///D:/Repo/com/httpclient-retry/0.0.1-SNAPSHOT/httpclient-retry-0.0.1-20201016.190157-1.jar
(11 KB at 197.8 KB/sec)
Overriding previous definition of reference to ant-tasks-atelier.classpath
{noformat}
My initial patch does work. Is anyone willing to create a test for this? Will
upload the branch for testing shortly.
> settings task does not load repositories defined into settings.xml
> ------------------------------------------------------------------
>
> Key: MRESOLVER-66
> URL: https://issues.apache.org/jira/browse/MRESOLVER-66
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
> Affects Versions: 1.3.1
> Reporter: lefebvre
> Priority: Major
> Attachments: MRESOLVER-66.log, MRESOLVER-66.xml
>
>
> my-settings.xml :
> {code:xml}
> <?xml version="1.0"?>
> <settings xmlns="http://maven.apache.org/SETTINGS/1.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd";>
> <interactiveMode>false</interactiveMode>
> <servers>
> <server>
> <id>my-repo</id>
> <configuration>
> <httpHeaders>
> <property>
> <name>Private-Token</name>
> <value>XXX</value>
> </property>
> </httpHeaders>
> </configuration>
> </server>
> </servers>
> <profiles>
> <profile>
> <id>enable-repos</id>
> <repositories>
> <repository>
> <id>central</id>
> <name>central</name>
> <url>http://repo1.maven.org/maven2</url>
> </repository>
> <repository>
> <id>my-repo</id>
> <name>my repository</name>
> <url>XXX</url>
> </repository>
> </repositories>
> </profile>
> </profiles>
> <activeProfiles>
> <activeProfile>enable-repos</activeProfile>
> </activeProfiles>
> </settings>
> {code}
>
> {{<settings file="my-settings.xml" globalfile="my-settings.xml"/>}}
>
> The resolver task does not try to resolve artifacts using "my-repo".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
