rfscholte commented on a change in pull request #9:
URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513752468



##########
File path: pom.xml
##########
@@ -66,8 +66,7 @@
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <maven.compiler.source>1.7</maven.compiler.source>
-    <maven.compiler.target>1.7</maven.compiler.target>
+    <maven.compiler.release>11</maven.compiler.release>

Review comment:
       It would make sense to  call JLink via toolchain, so there's no need for 
this requirement. Recently we've decided to make the minimum Java 8 for Maven 
plugins




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to