gnodet commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735264221
I think the problem raised in https://github.com/apache/maven/pull/402/commits/331e402b1a7f6e158444984d1272aeff18f54549 and https://github.com/apache/maven/pull/402/commits/aa285f20bc2c4aef9898e42e297dd43430ac2c11 are still valid with the proposed PR. Actually a bit worse since the ReactorModelCache now contains not only model data, but also a mapping from GA coordinates to Source. Maybe this map could be set on the `DefaultTransformerContext`. In all cases, the GA<->Source mapping is not really used as a cache (a cache should be optional and just avoids computing things multiple times) but as a storage (the `findRawModel` returns null the mapping has not been stored in the cache previously). I'm willing to rework my work on top of yours, but the above point makes it much more difficult. Could you consider revisit this point somehow ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
