[
https://issues.apache.org/jira/browse/MNG-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240104#comment-17240104
]
Adam Gent commented on MNG-7033:
--------------------------------
[~martinkanters]
I will add that our scripts (actually graalvm native image compiled java
programs + bash) now work around this issue by literally doing the internal
multi-module project dependency analysis to see if the project is in the
reactor. If it is than it is included as negative in the project list ({{-pl}})
(that was a fun bit of DFS graph programming I did over the break where I had
to remind myself that modules are actually dependents of multi-module and not
dependencies (which makes since)).
I have contemplated open sourcing the scripts + java. They basically generate
the correct {{-pl}} based on the last modified times for snapshots in the local
and target artifacts. It works most of the time and is much faster than letting
maven rebuild an entire project even incrementally.
> Excluded projects through -pl should not need to be in the reactor
> ------------------------------------------------------------------
>
> Key: MNG-7033
> URL: https://issues.apache.org/jira/browse/MNG-7033
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
> Affects Versions: 3.6.0, 3.6.1, 3.6.3
> Reporter: Adam Gent
> Priority: Major
>
> TLDR if you exclude a module using {{!module}} or {{-module}} with {{-pl}}
> that module needs to somehow be in the resolved reactor.
> We have custom build scripts (e.g. shells scripts or makes) that will make a
> certain subset of the project using {{-pl}}. However some modules we want to
> always exclude. (Yes we could use profiles but the maintenance of that
> solution is unacceptable to us).
> Thus if we do something like this:
> {code:sh}
> mvn install -pl "snaphop-cache,-snaphop-http" -amd
> {code}
> We may or not may not get the following depending on whether snaphop-cache
> has a downstream dependency on snaphop-http:
> {code}
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Could not find the selected project in the reactor:
> snaphop-http @
> [ERROR] Could not find the selected project in the reactor: snaphop-http ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
> Thus it becomes nontrivial to exclude a module. One has to know whether or
> not {{snaphop-cache}} will trigger {{snaphop-http}} to be in the reactor.
> Furthermore the command may fail if some one changes dependencies (not
> project structure or modules).
> I find that to be alarming. {{-pl}} shouldn't fail if dependencies change.
> Its notable that the following is completely fine:
> {code:sh}
> mvn install -pl "snaphop-cache,snaphop-http" -amd
> {code}
> Which is confusing and inconsistent that one can't then add {{-}}.
> My recommendation is if -pl can't find the exclusion module in the currently
> selected reactor is just ignores it or perhaps issues a warning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
