rfscholte commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735466896
@gnodet thanks for reviewing. It doesn't make sense to review it per commit, I would suggest to comment on the total changes. In the end these commit will be squashed into on, yes. File vs Raw vs Effective model `ModelBuilder.buildRawModel( File pomFile, int validationLevel, boolean locationTracking )` was actually never used in our codebase. Now returning the rawModel only works if there is a fileModel. This is different compared to Maven3, where the fileModel and rawModel are actually the same. FileModelSource vs ArtifactModelSource Yes, artifactModelSources are loaded from the repository, FileModelSources are from the reactor/multimodule. The main reason is that pom from a repository should NEVER be transformed. GA instead of GAV GA is required for versionless dependencies, i.e. if there is only one GA in the project, now we can use that version. If for a weird reason there are multiple versions, an exception is thrown, because Maven cannot select a version: https://github.com/apache/maven/pull/391/files#diff-8af144c3b53554dd804a30126d20926a7f93aa03b86fdc12613a2f5c2df2b15cR57-R72 SAX vs Stax I don't see the issues here. There is a need for chaining, hence the available XMLFilters made sense to me. For now I would like to stick to the current implementation, do an alpha-release and wait for feedback. ModelReader IIRC when I tried that several tests broke and I couldn't figure out how to solve that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
