pzygielo commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536894982
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
{
if ( "0".equals( getForkCount() ) )
{
- getConsoleLogger().warning( "The parameter forkCount should likely
not be 0, not forking a JVM for tests "
- + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+ getConsoleLogger().warning( "The parameter forkCount should likely
not be 0. Not forking a JVM for tests "
+ + "reduces test accuracy. Ensure to have a <forkCount> >= 1."
);
Review comment:
Thanks for checking - sure thing.
I was only bothered by the verb in first place. I have no opinion regarding
middle sentence.
I just had to retrigger Travis twice (once for failing _GitHub CI for *Nix /
build (macOS-latest)_, once for _GitHub CI for *Nix / build (ubuntu-latest)_)
without changing my changes (one can check diffs for my forced pushes). Only
then I marked this PR as ready for review and asked for one.
I have no intention to play with Travis again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
