sparsick commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537283535



##########
File path: 
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##########
@@ -35,11 +36,11 @@
 
 abstract class AbstractJLinkToolchainExecutor extends AbstractJLinkExecutor
 {
+    private static final Logger LOGGER = LoggerFactory.getLogger( 
AbstractJLinkToolchainExecutor.class );

Review comment:
       @elharo I looked in [other Maven code 
](https://github.com/apache/maven-artifact-transfer/blob/dfb1e61c4f5db6fe167b3d879a37ab5e25c8475c/src/main/java/org/apache/maven/shared/transfer/project/deploy/internal/DefaultProjectDeployer.java#L52)
 that use slf4j logger and there "LOGGER" is used. So I would prefer LOGGER




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to