[
https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248060#comment-17248060
]
Michael Osipov commented on MRELEASE-899:
-----------------------------------------
[~erharold], what is your opinion as XML expert?
[~kriegaex], we have issus which last 10+ years. This is simply an indication
either nobody cares or nobody can work on it. In this specific problem there
are workarounds. I do understand that from an editor's POV the LE should not
change, but MRELEASE is not an editor.
Moreover, I don't need an excuse. I can simply stop reacting because I owe you
nothing which I really don't want to to from a professional POV. So, I consider
that this request is valid, but am not happy with the PR. If no one is able to
provide such a detector in time I will consider to merge the PR with an
immediate deprecation of this feature with a future replacement of an automatic
(implicit) mode.
[~ggregory], do you think it is work to a line ending separator dectector in
Commons IO? The simplest one would scan to the first LE, a better one would
return: {{NONE}}, {{LF}}, {{CR}}, {{CRLF}}, {{MIXED}}. One should also be able
to specifiy the amount of lines to scan until {{MIXED}} might occur.
> release:prepare should not change the line separator but detect effective
> line separator from pom.xml
> -----------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-899
> URL: https://issues.apache.org/jira/browse/MRELEASE-899
> Project: Maven Release Plugin
> Issue Type: Improvement
> Reporter: Ralph van Etten
> Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it
> rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is
> released sometimes under Windows and sometimes under Linux (because of its
> different line separators).
> (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the
> systems line separator but the line separator that is already used in the
> pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm
> someone else.
> Therefore it would be an great feature when there would be an property that
> define the expected behaviour, maybe in the same way it is done by the
> maven-assembly-plugin's property fileSet.lineEnding
> (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
