gnodet edited a comment on pull request #399: URL: https://github.com/apache/maven/pull/399#issuecomment-743443752
> You have proposed two different solutions in the JIRA issue. Which have you chosen? @michael-o I basically reverted part of the change so that an exception is thrown if there is a cycle in the imports. I think that's a rare case, given this regression is quite old, but the code in the current state does not make any sense. In the current code, the `importDependencyManagement` method takes an `importIds` which is a new list at each invocation. > I am also a bit confused about the change. You pass a new parameter: `importIds`, but in that method it is not used. Can you please clarify? I think the diff is a bit unclear because all the code wasn't removed in the first place, so I just add to add some pieces, which don't make sense by themselves, and you need to look at the whole code. The `importIds` is a collection of ids which is not initialized once and then passed into the potentially recursive calls to `build` and `importDependencyManagement` to detect a cycle where a BOM would itself import another BOM which would import the first one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
