michael-o commented on a change in pull request #12:
URL: https://github.com/apache/maven-deploy-plugin/pull/12#discussion_r541561101
##########
File path: src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java
##########
@@ -248,19 +249,40 @@ else if ( !ArtifactUtils.isSnapshot( project.getVersion()
) && altReleaseDeploym
{
getLog().info( "Using alternate deployment repository " +
altDeploymentRepo );
- Matcher matcher = ALT_REPO_SYNTAX_PATTERN.matcher(
altDeploymentRepo );
+ Matcher matcher = ALT_LEGACY_REPO_SYNTAX_PATTERN.matcher(
altDeploymentRepo );
- if ( !matcher.matches() )
+ if ( matcher.matches() )
{
- throw new MojoFailureException( altDeploymentRepo, "Invalid
syntax for repository.",
- "Invalid syntax for
alternative repository. Use \"id::url\"." );
+ getLog().warn( "Legacy form of alternate deployment parameter
used, update parameter to match plugin version." );
Review comment:
Very nice! As I have said it is all about greedy regex....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
