[
https://issues.apache.org/jira/browse/MDEPLOY-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248339#comment-17248339
]
Tamás Cservenák commented on MDEPLOY-279:
-----------------------------------------
But still, that would fail at deploy attempt, too late IMHO. I think current PR
reflects the intent the best:
* fail fast build with any (legacy, insane) altDeployment string
* provide useful error message when legacy used (user can just use it:
copy+paste)
* works only with "modern" syntax
This is most fool proof and even "hasty proof" (for my case) as my "reproducer"
that is about switching m-d-p between 2.x and 3.x would simply fail, as I was
unaware that 3.x changed syntax, and expected to have "same thing" for same CLI
input but different plugin version, which, is not true.
> Missing validation of altDeploymentRepository mojo parameter
> ------------------------------------------------------------
>
> Key: MDEPLOY-279
> URL: https://issues.apache.org/jira/browse/MDEPLOY-279
> Project: Maven Deploy Plugin
> Issue Type: Bug
> Components: deploy:deploy
> Affects Versions: 3.0.0-M1
> Reporter: Tamás Cservenák
> Assignee: Michael Osipov
> Priority: Major
>
> Reproducer: [https://github.com/cstamas/mvn-md-bug]
> Command like: {{mvn clean deploy
> -DaltDeploymentRepository=localhost-nexus::default::http://localhost:8081/content/repositories/snapshots/}}
> (w/ 3.0.0-M1 m-d-p, needs POM edit)
> As seen in MDEPLOY-274, m-d-p 2.x succeeds, while 3.x fails with _same CLI
> command line_.
> True, the parameter did change between 2.x and 3.x, still IMO validation is
> missing: 3.x should either fail early (not at attempted deploy w/o
> credentials) or at least WARN about "not recognized parameter", or best.
> accept 2.x format as well, but only if layout is "default".
> Maybe some other changed parameters needs some validation as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
