[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #14: [MJLINK-41] add support for --add-options argument (JDK14+).

[GitBox]

bmarwell commented on pull request #14:
URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-746507505


   @rmannibucau please re-review.
   
   Things to watch:
   * Language and spelling
   * Is  the MojoFailureException thrown when it shouldn’t? See this line: 
     `            if ( !toolchainPrivate.matchesRequirements( singletonMap( 
"jdk", "14" ) ) )    `
   * Are the ITs properly defined?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org