ccorsi opened a new pull request #36:
URL: https://github.com/apache/maven-compiler-plugin/pull/36
The following changes resolves two different issues. The first is the case
that
the we are creating a multi-version jar file that by default is not
modularized.
If tests are created that will be testing the modularized part of the
multi-version
jar file. Then the build was generating an UnsupportedOperationException
because
it assumed that we were using a non-modularized jar file with a modularized
test.
The second issue was related to the fact that the test are using dependency
jars
that are not modularized. The generated javac command was only producing the
required module path and nulled out the classpath. This was causing the
building
of the test sources to fail. The was caused because those non-modularized
jar
files were not part of the classpath.
The current set of changes solves the first issue by determining if the
project
jar file is a multi-version jar file. If it is, it will then set the main
module
descriptor to the latest version less than or equal to the defined release
attribute.
It solves the second issue by adding all non-modularized jar files to the
class path. It does not remove them from the defined module path to be
consistent with how it was working.
Finally an integration test was created that reproduced the above issues.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MPH-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
