philsttr opened a new pull request #15:
URL: https://github.com/apache/maven-deploy-plugin/pull/15
[MDEPLOY-265] Maintain backwards compatibility for alt*DeploymentRepository
in id::default::url format
The legacy format (<=2.x) of alt\*DeploymentRepository is id::layout::url.
The new format (>= 3.x) of alt\*DeploymentRepository is id::url, which is
equivalent to id::default:url from the legacy format.
This change introduces backwards compatibility with 2.x by supporting
alt\*DeploymentRepository values in the id::layout::url format if and only if
the layout is equal to "default". The "default" layout is the most commonly
used layout, so this should maintain backwards compatibility with the large
majority of projects using the alt\*DeploymentRepository properties.
Usage of the legacy format with the "default" layout will result in a
warning message being logged.
Usage of the legacy format with layouts other than "default" will result in
an exception being thrown.
One use case this change will help is when alt\*DeploymentRepository
properties are set in common maven settings.xml files used for a large number
of projects. For example, a CI server. Keeping backwards compatibilty with
id::default::url allows those settings.xml files to be used regardless of the
version of maven-deploy-plugin used by the projects built on that CI server.
Projects can individually upgrade their maven-deploy-plugin without breaking.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MPH) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MPH-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
