rfscholte commented on a change in pull request #415:
URL: https://github.com/apache/maven/pull/415#discussion_r549107198
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -569,6 +570,20 @@ else if ( cliRequest.commandLine.hasOption(
CLIManager.BATCH_MODE )
}
}
+ /**
+ * Disables the colour output in the case that the {@link
CLIManager#BATCH_MODE} option
+ * or {@link CLIManager#LOG_FILE} option was given (or both). In those
cases, ANSI output is never feasible.
+ * @param cliRequest the arguments as request pojo.
+ */
+ private void disableColorsInLogfileOrBatch( CliRequest cliRequest )
Review comment:
I'd prefer a more general method name: applyColorMode. This way we can
add more logic when necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
