[
https://issues.apache.org/jira/browse/MJLINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255933#comment-17255933
]
Herve Boutemy commented on MJLINK-62:
-------------------------------------
yes, given we use the PrintWriter API of ToolProvider
[https://docs.oracle.com/javase/9/docs/api/java/util/spi/ToolProvider.html],
it's better to keep the Character/String content as-is instead of butchering
three times (once on {{new PrintWriter(OutputStream)}}, the second one on
{{baosOut.toString( "UTF-8" )}} and the third one that is inconsistent with
previous one {{baosErr.toString()}})
> Replace ByteArrayOutputStream with StringWriter
> -----------------------------------------------
>
> Key: MJLINK-62
> URL: https://issues.apache.org/jira/browse/MJLINK-62
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: encoding
> Fix For: 3.2.0
>
>
> Currently a BAOS exists to capture JLinks output.
> Replacing it with StringWriter would preserve the platform’s encoding.
> Reference:
> https://github.com/apache/maven-jlink-plugin/blob/f8bdf5050c266854524aaa51eb36109c00ca692a/src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java#L72-L75
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
